Ignore fields with __prefix__ in id #332
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #332 +/- ##
=======================================
Coverage 80.42% 80.42%
=======================================
Files 8 8
Lines 470 470
Branches 68 68
=======================================
Hits 378 378
Misses 60 60
Partials 32 32 Continue to review full report at Codecov.
|
leibowitz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
django-smart-selects is currently initialising fields that aren't displayed on screen (including
__prefix__in the id)https://docs.djangoproject.com/en/3.2/topics/forms/formsets/#empty-form
These are usually created for one/many-to-many relationships, and are cloned when a user clicks on the "add another" within the admin. The
__prefix__is then replaced with an index number (starting at 0)There is a lot of code spread around to skip fields that include
__prefix__:https://github.com/django/django/blob/ca9872905559026af82000e46cde6f7dedc897b6/django/contrib/admin/static/admin/js/SelectFilter2.js#L11-L14
https://github.com/django/django/blob/ca9872905559026af82000e46cde6f7dedc897b6/django/contrib/admin/static/admin/js/autocomplete.js#L33